Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5697#discussion_r29178161
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala 
---
    @@ -556,6 +579,28 @@ class SparseVector(
           i += 1
         }
       }
    +
    +  override def hashCode(): Int = {
    --- End diff --
    
    This is a contract in Java (http://en.wikipedia.org/wiki/Java_hashCode()):
    
    > The general contract for overridden implementations of this method is 
that they behave in a way consistent with the same object's equals() method: 
that a given object must consistently report the same hash value (unless it is 
changed so that the new version is no longer considered "equal" to the old), 
and that two objects which equals() says are equal must report the same hash 
value.
    
    So `sv == dv` -> `sv.## == dv.##`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to