cloud-fan commented on a change in pull request #31601:
URL: https://github.com/apache/spark/pull/31601#discussion_r580257116
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala
##########
@@ -54,38 +54,38 @@ class EncoderResolutionSuite extends PlanTest {
val encoder = ExpressionEncoder[StringLongClass]
// int type can be up cast to long type
- val attrs1 = Seq('a.string, 'b.int)
+ val attrs1 = Seq(attr("a").string, attr("b").int)
Review comment:
My general idea is, previous the DSL is based on symbol, can we update
the DSL (those implicts) so that it's based on string? Ideally we should simply
replace `'abc` to `"abc"` in the test code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
