sarutak commented on a change in pull request #31601:
URL: https://github.com/apache/spark/pull/31601#discussion_r580271651
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala
##########
@@ -54,38 +54,38 @@ class EncoderResolutionSuite extends PlanTest {
val encoder = ExpressionEncoder[StringLongClass]
// int type can be up cast to long type
- val attrs1 = Seq('a.string, 'b.int)
+ val attrs1 = Seq(attr("a").string, attr("b").int)
Review comment:
It was my first idea but I thought it might be confusable that `"abc"`
with implicit conversion doesn't look like an `attribute`. But DSL is for
internal so it might be acceptable. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
