linhongliu-db commented on a change in pull request #31606:
URL: https://github.com/apache/spark/pull/31606#discussion_r580734338
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -921,7 +921,9 @@ class Analyzer(override val catalogManager: CatalogManager)
}
def lookupTempView(
- identifier: Seq[String], isStreaming: Boolean = false):
Option[LogicalPlan] = {
+ identifier: Seq[String],
+ isStreaming: Boolean = false,
+ performCheck: Boolean = false): Option[LogicalPlan] = {
Review comment:
For `UnresolvedView`, `UnresolvedTable`, `UnresolvedTableOrView`, we use
`lookupTempView` to check whether the temp view exists, but it's ok to skip the
checkAnalysis. For example:
1. In DropView, the UnresolvedView will change to ResolvedView even the
referred table is dropped.
2. When resolving `UnresolvedTable`, if it is a view, should analyzer should
throw `expectTableNotViewError` rather than `table or view not found`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
