cloud-fan commented on a change in pull request #31606:
URL: https://github.com/apache/spark/pull/31606#discussion_r580888632



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -921,7 +921,9 @@ class Analyzer(override val catalogManager: CatalogManager)
     }
 
     def lookupTempView(
-        identifier: Seq[String], isStreaming: Boolean = false): 
Option[LogicalPlan] = {
+        identifier: Seq[String],
+        isStreaming: Boolean = false,
+        performCheck: Boolean = false): Option[LogicalPlan] = {

Review comment:
       @imback82 This is something we should improve. For `SELECT ... FROM 
view` and `DROP VIEW view`, the way to lookup the view should be different.
   
   For `SELECT ... FROM view`, we must fully resolve the view, as we need to 
execute it.
   
   For `DROP VIEW view`, we only need to get the view metadata entry. The same 
to `ALTER VIEW ...`.
   
   I think we should change how we resolve `UnresolvedTableOrView` and 
`UnresolvedView`, to only get the view metadata.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to