AngersZhuuuu commented on a change in pull request #31522:
URL: https://github.com/apache/spark/pull/31522#discussion_r581037797
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala
##########
@@ -192,6 +192,10 @@ class BasicWriteJobStatsTracker(
new BasicWriteTaskStatsTracker(serializableHadoopConf.value)
}
+ override def processCommitDuration(duration: Long): Unit = {
+ metrics(BasicWriteJobStatsTracker.DURATION_FILE_COMMIT).set(duration)
+ }
+
override def processStats(stats: Seq[WriteTaskStats]): Unit = {
Review comment:
> Instead of adding a new method, we can probably just add one more
parameter here. Then we don't need to worry about the execution order of
`processCommitDuration` and `processStats`.
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
