AngersZhuuuu commented on a change in pull request #31522:
URL: https://github.com/apache/spark/pull/31522#discussion_r582049509
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
##########
@@ -221,7 +221,7 @@ object FileFormatWriter extends Logging {
val (_, duration) = Utils.timeTakenMs { committer.commitJob(job,
commitMsgs) }
logInfo(s"Write Job ${description.uuid} committed. Elapsed time:
$duration ms.")
- processStats(description.statsTrackers, ret.map(_.summary.stats))
+ processStats(description.statsTrackers, ret.map(_.summary.stats),
duration)
Review comment:
Some times after task all completed, we wait a long time then job
finished, it's always cost on job commit and metadata handling such as
`externalCatalog.loadDynamicPartition()` etc.
These duration information is important when it's slow when we want to
compare job's performance. Since when hdfs is unstable, file operation will
cost more time.
Also I want to add metrics about metadata handling time after job committed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
