sririshindra commented on pull request #31477: URL: https://github.com/apache/spark/pull/31477#issuecomment-787485609
> Can we improve the test coverage? Build a new suite instead of modify the existing one. > > cc @cloud-fan @maryannxue @rednaxelafx @gatorsmile Could you please elaborate on what do you mean by a new Suite? Do mean to say that there should be a separate suite for the metric that is being proposed in this PR or are you suggesting that the SQLMetrics Suite itself should be refactored into multiple test Suites (maybe a seperate test Suite for Join based tests, maybe further divide each join based tests with its own test Suite). Also, do you think this new Suite should be done as part of this PR or do you think that a separate follow up PR would be more appropriate? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
