sririshindra commented on pull request #31477: URL: https://github.com/apache/spark/pull/31477#issuecomment-787552221
> A new suite is preferred here. Creating a new suite for Join-specific SQLMetrics is preferred here, because it has to cover various different cases, including different join types, different join algorithms, whole-stage on/off, and different runtime shortcuts. Also, stream-stream and batch-stream joins should also be tested. @gatorsmile I refactored the existing test Suite and created a new Suite that contains all the join specifc tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
