zhengruifeng commented on a change in pull request #31588:
URL: https://github.com/apache/spark/pull/31588#discussion_r584521309
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/VectorSlicer.scala
##########
@@ -110,22 +110,21 @@ final class VectorSlicer @Since("1.5.0") (@Since("1.5.0")
override val uid: Stri
}
// Prepare output attributes
- val inds = getSelectedFeatureIndices(dataset.schema)
- val selectedAttrs = inputAttr.attributes.map { attrs =>
- inds.map(index => attrs(index))
- }
+ val selectedIndices = getSelectedFeatureIndices(dataset.schema)
+ val selectedAttrs = inputAttr.attributes.map { attrs =>
selectedIndices.map(attrs.apply) }
val outputAttr = selectedAttrs match {
case Some(attrs) => new AttributeGroup($(outputCol), attrs)
- case None => new AttributeGroup($(outputCol), inds.length)
+ case None => new AttributeGroup($(outputCol), selectedIndices.length)
}
- // Select features
+ val sorted = selectedIndices.length > 1 &&
selectedIndices.sliding(2).forall(t => t(1) > t(0))
Review comment:
If we create an additional class (VectorSlicer) for this, I guess we can
not use it elsewhere. Since this slicing indices can not be a member of vector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
