Ngone51 commented on a change in pull request #31664:
URL: https://github.com/apache/spark/pull/31664#discussion_r585297062
##########
File path:
core/src/test/scala/org/apache/spark/shuffle/sort/SortShuffleManagerSuite.scala
##########
@@ -131,4 +139,40 @@ class SortShuffleManagerSuite extends SparkFunSuite with
Matchers {
)))
}
+ test("Shuffle data can be cleaned up whether
spark.shuffle.useOldFetchProtocol=true/false") {
Review comment:
We usually test different config values like this:
```scala
Seq(true, false).foreach { value =>
test("Shuffle data can be cleaned up whether
spark.shuffle.useOldFetchProtocol=value") {
....
conf.set(spark.shuffle.useOldFetchProtocol, value)
...
}
```
Could you follow this way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
