Ngone51 commented on a change in pull request #31664:
URL: https://github.com/apache/spark/pull/31664#discussion_r588883452
##########
File path: core/src/test/scala/org/apache/spark/ShuffleSuite.scala
##########
@@ -419,6 +424,31 @@ abstract class ShuffleSuite extends SparkFunSuite with
Matchers with LocalSparkC
manager.unregisterShuffle(0)
}
+
+ test(s"SPARK-34541: shuffle can be removed when
spark.shuffle.useOldFetchProtocol=true") {
Review comment:
nit: `SPARK-34541: shuffle files should be removed normally`
(`spark.shuffle.useOldFetchProtocol=true` is not valid for `ShuffleSuite`.)
##########
File path:
core/src/test/scala/org/apache/spark/shuffle/sort/SortShuffleManagerSuite.scala
##########
@@ -130,5 +130,4 @@ class SortShuffleManagerSuite extends SparkFunSuite with
Matchers {
mapSideCombine = true
)))
}
-
Review comment:
nit: revert the unrelated change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
