karenfeng commented on a change in pull request #31666:
URL: https://github.com/apache/spark/pull/31666#discussion_r586652486
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -988,31 +988,43 @@ class Analyzer(override val catalogManager:
CatalogManager)
* columns are not accidentally selected by *.
*/
object AddMetadataColumns extends Rule[LogicalPlan] {
- import
org.apache.spark.sql.execution.datasources.v2.DataSourceV2Implicits._
+ import org.apache.spark.sql.catalyst.util._
+
+ private def getMetadataAttributes(plan: LogicalPlan): Seq[Attribute] = {
+ lazy val childMetadataOutput = plan.children.flatMap(_.metadataOutput)
+ plan.expressions.flatMap(_.collect {
+ case a: Attribute if a.isMetadataCol => a
+ case a: Attribute if childMetadataOutput.exists(_.exprId == a.exprId)
=>
Review comment:
This occurs in the case that a column is resolved below the level at
which it becomes labeled as metadata. For the NATURAL/USING JOIN, this occurs
when the column is resolved at the level of the root table - it is only labeled
as hidden when it is used as a key column in the join.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
