karenfeng commented on a change in pull request #31666:
URL: https://github.com/apache/spark/pull/31666#discussion_r587698038
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -76,6 +77,13 @@ case class Project(projectList: Seq[NamedExpression], child:
LogicalPlan)
override lazy val validConstraints: ExpressionSet =
getAllValidConstraints(projectList)
+
+ val hiddenOutputTag: TreeNodeTag[Seq[Attribute]] =
TreeNodeTag[Seq[Attribute]]("hiddenOutput")
+
+ override def metadataOutput: Seq[Attribute] = {
+ child.metadataOutput ++
+ getTagValue(hiddenOutputTag).getOrElse(Seq.empty[Attribute])
Review comment:
We could make this more generic by adding this `LogicalPlan`'s
`metadataOutput`, but that would complicate how we can add these hidden columns
in `AddMetadataColumns`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
