maropu commented on a change in pull request #31736:
URL: https://github.com/apache/spark/pull/31736#discussion_r588883010
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/JoinCodegenSupport.scala
##########
@@ -29,8 +29,12 @@ import org.apache.spark.sql.execution.{CodegenSupport,
SparkPlan}
trait JoinCodegenSupport extends CodegenSupport with BaseJoinExec {
/**
- * Generate the (non-equi) condition used to filter joined rows. This is
used in Inner, Left Semi
- * and Left Anti joins.
+ * Generate the (non-equi) condition used to filter joined rows.
+ * This is used in Inner, Left Semi and Left Anti joins.
+ *
+ * @return Variable name for row of build side.
Review comment:
nit: How about this instead?
```
* @return Tuple of variable name for row of build side, generated code
for condition,
* and generated code for variables of build side.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
