hiboyang commented on a change in pull request #31763:
URL: https://github.com/apache/spark/pull/31763#discussion_r589964037
##########
File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala
##########
@@ -52,6 +52,13 @@ private[spark] sealed trait MapStatus {
* partitionId of the task or taskContext.taskAttemptId is used.
*/
def mapId: Long
+
+ /**
+ * Extra metadata for map status. This could be used by different
ShuffleManager implementation
+ * to store information they need. For example, a Remote Shuffle Service
ShuffleManager could
+ * store shuffle server information and let reducer task know where to fetch
shuffle data.
+ */
+ def metadata: Option[Serializable]
Review comment:
Yes, in this case, agree with you that this PR is a different topic from
[SPARK-25299](https://issues.apache.org/jira/browse/SPARK-25299), and the
community not have enough bandwidth to work on these two significant projects
concurrently. This PR is adding a simple change to make it possible that
different custom shuffle managers could add their own metadata inside the
MapStatus object. Could we proceed to review this PR then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
