hiboyang commented on a change in pull request #31763:
URL: https://github.com/apache/spark/pull/31763#discussion_r590917443
##########
File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala
##########
@@ -52,6 +52,13 @@ private[spark] sealed trait MapStatus {
* partitionId of the task or taskContext.taskAttemptId is used.
*/
def mapId: Long
+
+ /**
+ * Extra metadata for map status. This could be used by different
ShuffleManager implementation
+ * to store information they need. For example, a Remote Shuffle Service
ShuffleManager could
+ * store shuffle server information and let reducer task know where to fetch
shuffle data.
+ */
+ def metadata: Option[Serializable]
Review comment:
I feel [SPARK-31801](https://issues.apache.org/jira/browse/SPARK-31801)
is very big, and may take very long time to finish. Could we merge this PR
first?
If [SPARK-31801](https://issues.apache.org/jira/browse/SPARK-31801) find a
better way to support it and break `getAllMapOutputStatusMetadata`, it is
actually a good thing :) We could have multiple iterations. This PR is the
first iteration with very small change.
[SPARK-31801](https://issues.apache.org/jira/browse/SPARK-31801) is the
iteration after that. The latter does not need to block the former one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
