AngersZhuuuu commented on a change in pull request #31611:
URL: https://github.com/apache/spark/pull/31611#discussion_r592035862
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -113,10 +113,15 @@ private[spark] class AppStatusStore(
}
}
- def stageData(stageId: Int, details: Boolean = false): Seq[v1.StageData] = {
+ def stageData(
+ stageId: Int,
+ details: Boolean = false,
+ withSummaries: Boolean = false,
Review comment:
> Do we need both params? doesn't this have summaries iff quantiles
isn't empty?
two params is necessary, yea, we need a check if quantiles is empty, we
apply a default value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
