AngersZhuuuu commented on a change in pull request #31611:
URL: https://github.com/apache/spark/pull/31611#discussion_r592040960



##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -113,10 +113,15 @@ private[spark] class AppStatusStore(
     }
   }
 
-  def stageData(stageId: Int, details: Boolean = false): Seq[v1.StageData] = {
+  def stageData(
+    stageId: Int,
+    details: Boolean = false,
+    withSummaries: Boolean = false,

Review comment:
       > when would say withSummaries be true and quantiles be empty for 
example?
   ```
   ?withSummaries=true&quantiles=
   ```
   Maybe this case,  I need to try and test, then update the code.
   
   > when is it false while quantiles is non-empty?
   
   We just ignore this, since quantiles only effect when withSummaries=true




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to