yaooqinn commented on a change in pull request #31804:
URL: https://github.com/apache/spark/pull/31804#discussion_r592075370
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -514,7 +514,8 @@ object ShowTables {
def getOutputAttrs: Seq[Attribute] = Seq(
AttributeReference("namespace", StringType, nullable = false)(),
AttributeReference("tableName", StringType, nullable = false)(),
- AttributeReference("isTemporary", BooleanType, nullable = false)())
+ AttributeReference("isTemporary", BooleanType, nullable = false)(),
+ AttributeReference("isView", BooleanType, nullable = false)())
Review comment:
Usually, most modern databases store `tableType` as a string column in
`INFORMATION_SCHEMA.TABLES`.
On the reading side, they also return a string value for it.
FYI,
https://docs.google.com/spreadsheets/d/1LeHYbGCDjgr-rYwQMlHBhJbeDxjOVuUatozgvKdxq6Y/edit#gid=0
Besides, as `SHOW TABLES` is not ANSI standard, so it might be good for us
to follow the JDBC standard. Then we can make our command and JDBC meta
operation consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
