yaooqinn commented on a change in pull request #31804:
URL: https://github.com/apache/spark/pull/31804#discussion_r592087833
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -514,7 +514,8 @@ object ShowTables {
def getOutputAttrs: Seq[Attribute] = Seq(
AttributeReference("namespace", StringType, nullable = false)(),
AttributeReference("tableName", StringType, nullable = false)(),
- AttributeReference("isTemporary", BooleanType, nullable = false)())
+ AttributeReference("isTemporary", BooleanType, nullable = false)(),
+ AttributeReference("isView", BooleanType, nullable = false)())
Review comment:
Yes, another benefit for using string is if we decide to subdivide
tables to something like `SYSTEM TABLE`/`BASE TABLE`, `xxx TABLE` e.t.c, we
won't break then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
