attilapiros commented on a change in pull request #31818:
URL: https://github.com/apache/spark/pull/31818#discussion_r593238434
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
##########
@@ -1586,6 +1591,30 @@ class DatasetSuite extends QueryTest with
SharedSQLContext {
}
}
}
+
+ test("SPARK-34726: Fix collectToPython timeouts") {
+ val listener = new QueryExecutionListener {
+ override def onFailure(funcName: String, qe: QueryExecution, exception:
Exception): Unit = {}
+
+ override def onSuccess(funcName: String, qe: QueryExecution, duration:
Long): Unit = {
+ // Longer than 15s in `PythonServer.setupOneConnectionServer`
Review comment:
Let's extract the 15000 into a `private[spark] var` as member:
https://github.com/apache/spark/blob/6b18cc752379387dd13c009490b54be823cf2437/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala#L899
And add a comment above `// visible for testing`.
Then we can speed up this single test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
