peter-toth commented on a change in pull request #31818:
URL: https://github.com/apache/spark/pull/31818#discussion_r593247824
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
##########
@@ -1586,6 +1591,30 @@ class DatasetSuite extends QueryTest with
SharedSQLContext {
}
}
}
+
+ test("SPARK-34726: Fix collectToPython timeouts") {
+ val listener = new QueryExecutionListener {
+ override def onFailure(funcName: String, qe: QueryExecution, exception:
Exception): Unit = {}
+
+ override def onSuccess(funcName: String, qe: QueryExecution, duration:
Long): Unit = {
+ // Longer than 15s in `PythonServer.setupOneConnectionServer`
+ Thread.sleep(20 * 1000)
Review comment:
Yes, we need to wait a bit longer than the timeout. Without the fix in
`Dataset.collectToPython` this UT fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
