maropu commented on a change in pull request #31804:
URL: https://github.com/apache/spark/pull/31804#discussion_r593636880
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -510,11 +510,21 @@ case class ShowTables(
override def children: Seq[LogicalPlan] = Seq(namespace)
}
-object ShowTables {
+trait ShowTablesLegacyHelper {
+ def getOutputAttrs: Seq[Attribute]
Review comment:
Is this a good idea that the code to handle this legacy behaviour
depends on `trait`? If we remove this legacy behaviour in far future and we
remove this `trait`, the change can lead to binary-incompatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
