yaooqinn commented on a change in pull request #31804:
URL: https://github.com/apache/spark/pull/31804#discussion_r593906834



##########
File path: sql/core/src/test/resources/log4j.properties
##########
@@ -22,7 +22,7 @@ log4j.rootLogger=INFO, CA, FA
 log4j.appender.CA=org.apache.log4j.ConsoleAppender
 log4j.appender.CA.layout=org.apache.log4j.PatternLayout
 log4j.appender.CA.layout.ConversionPattern=%d{HH:mm:ss.SSS} %p %c: %m%n
-log4j.appender.CA.Threshold = WARN
+log4j.appender.CA.Threshold = FATAL

Review comment:
       > But the current threshold (WARN) can help catch a bug like the 
following early: [#31273 
(comment)](https://github.com/apache/spark/pull/31273#issuecomment-785854571)
   
   These warning messages still can be found in the `unit-tests.log`s. I don't 
see much difference as a warning message can still be simply ignored.
   
   But when we encounter test failures but got omitted by the CI, it is hard 
for us to locate  to them. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to