Ngone51 commented on a change in pull request #31835:
URL: https://github.com/apache/spark/pull/31835#discussion_r594895251
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
##########
@@ -671,6 +671,19 @@ class AnalysisSuite extends AnalysisTest with Matchers {
Project(Seq(UnresolvedAttribute("temp0.a"),
UnresolvedAttribute("temp1.a")), join))
}
+ test("SPARK-34741: Avoid ambiguous reference in MergeIntoTable") {
+ val cond = 'a > 1
+ assertAnalysisError(
Review comment:
> For UPDATE SET a = source.a, I think it works before and after this
fix. @Ngone51 can you confirm?
Yes, it works before and after this fix.
The reason why we need `source.a` is `ReplaceNullWithFalseInPredicateSuite`
can fail with the ambiguous reference error after we added the dedup step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
