cloud-fan commented on a change in pull request #31835:
URL: https://github.com/apache/spark/pull/31835#discussion_r595754057
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceNullWithFalseInPredicateSuite.scala
##########
@@ -456,15 +456,21 @@ class ReplaceNullWithFalseInPredicateSuite extends
PlanTest {
private def testMerge(originalCond: Expression, expectedCond: Expression):
Unit = {
val func = (rel: LogicalPlan, expr: Expression) => {
+ val target = rel.as("target")
+ val source = rel.as("source")
val assignments = Seq(
- Assignment('i, 'i),
- Assignment('b, 'b),
- Assignment('a, 'a),
- Assignment('m, 'm)
+ Assignment(UnresolvedAttribute("i"), UnresolvedAttribute("source.i")),
+ Assignment(UnresolvedAttribute("b"), UnresolvedAttribute("source.b")),
+ Assignment(UnresolvedAttribute("a"), UnresolvedAttribute("source.a")),
+ Assignment(UnresolvedAttribute("m"), UnresolvedAttribute("source.m"))
Review comment:
Actually we don't have to test self-merge here. Can we create a new
relation for testing merge? so that we don't need to rewrite the conditions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
