cloud-fan commented on a change in pull request #31152:
URL: https://github.com/apache/spark/pull/31152#discussion_r595796377
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/RowQueue.scala
##########
@@ -174,7 +174,8 @@ private[python] case class HybridRowQueue(
tempDir: File,
numFields: Int,
serMgr: SerializerManager)
- extends MemoryConsumer(memManager) with RowQueue {
+ extends MemoryConsumer(memManager, memManager.pageSizeBytes(),
memManager.getTungstenMemoryMode)
Review comment:
`OnHeapMemoryConsumer` doesn't help as we still need to change every
memory consumer that is on-heap only.
How about we add one more constructor to take a `MemoryManager` and
`MemoryMode`? then the page size can still from the `MemoryManager`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
