cloud-fan commented on a change in pull request #31152:
URL: https://github.com/apache/spark/pull/31152#discussion_r596026661
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -523,7 +523,7 @@ private[joins] object UnsafeHashedRelation {
* see
http://java-performance.info/implementing-world-fastest-java-int-to-int-hash-map/
*/
private[execution] final class LongToUnsafeRowMap(val mm: TaskMemoryManager,
capacity: Int)
- extends MemoryConsumer(mm) with Externalizable with KryoSerializable {
+ extends MemoryConsumer(mm, MemoryMode.OFF_HEAP) with Externalizable with
KryoSerializable {
Review comment:
This should be ON_HEAP, as the data is stored in `page: Array[Long]`
which is a long array on the heap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
