Ngone51 commented on a change in pull request #31876:
URL: https://github.com/apache/spark/pull/31876#discussion_r596606151
##########
File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala
##########
@@ -28,16 +28,23 @@ import org.apache.spark.internal.config
import org.apache.spark.storage.BlockManagerId
import org.apache.spark.util.Utils
+trait Location extends Externalizable {
+ def host: String
+ def port: Int
+ def hostPort: String
+ def executorId: String = "unknown"
Review comment:
For "store extra information", I think implementors can add whatever
they want only if they're serializable. e.g., extra info can be
`Option[Serializable]` or `Map[String, String]`.
But I did think about adding a common `StorageType` class to `Location`. For
example, a valid use case is that we could know from it whether the storage is
reliable (e.g., `location.storageType.isReliable`) so we can decide whether to
apply "decommission" on such storage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
