Ngone51 commented on a change in pull request #31876:
URL: https://github.com/apache/spark/pull/31876#discussion_r598457153
##########
File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala
##########
@@ -28,16 +28,23 @@ import org.apache.spark.internal.config
import org.apache.spark.storage.BlockManagerId
import org.apache.spark.util.Utils
+trait Location extends Externalizable {
Review comment:
Because the `BlockManagerId` already used `Externalizable` and we want
to make the `BlockManagerId` as a default implementation of `Location` for
Spark.
A possible way to let `Location` extends `Serializable` is to let
`BlockManagerId` extends `Serializable` directly too. But we need to figure out
whether serializers could handle `topologyInfo_: Option[String]` properly as
`topologyInfo_` now is handled manually in `readExternal/writeExternal`:
https://github.com/apache/spark/blob/8218b488035049434271dc9e3bd5af45ffadf0fd/core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala#L71-L86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
