Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29301372
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -41,13 +42,15 @@ case class AggregateEvaluation(
* @param groupingExpressions expressions that are evaluated to determine
grouping.
* @param aggregateExpressions expressions that are computed for each
group.
* @param child the input data source.
+ * @param unsafeEnabled whether to allow Unsafe-based aggregation buffers
to be used.
*/
@DeveloperApi
case class GeneratedAggregate(
partial: Boolean,
groupingExpressions: Seq[Expression],
aggregateExpressions: Seq[NamedExpression],
- child: SparkPlan)
+ child: SparkPlan,
+ unsafeEnabled: Boolean)
--- End diff --
nit: typically place children last (although we aren't great about
following this convention)...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
