Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29301548
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -207,7 +210,23 @@ private[spark] class Executor(
// Run the actual task and measure its runtime.
taskStart = System.currentTimeMillis()
- val value = task.run(taskAttemptId = taskId, attemptNumber =
attemptNumber)
+ var succeeded: Boolean = false
+ val value = try {
+ val value = task.run(taskAttemptId = taskId, attemptNumber =
attemptNumber)
+ succeeded = true
+ value
+ } finally {
+ // Release managed memory used by this task
+ val freedMemory = taskMemoryManager.cleanUpAllAllocatedMemory()
+ if (succeeded && freedMemory > 0) {
--- End diff --
I also agree that we should enforce this for failures as well. In the
worst case, I suppose our failure message is masked by a memory leak message,
but that's fine for now as this is disabled by default and is only used in
tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
