karenfeng commented on a change in pull request #31666:
URL: https://github.com/apache/spark/pull/31666#discussion_r608857259



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -77,6 +77,14 @@ case class Project(projectList: Seq[NamedExpression], child: 
LogicalPlan)
 
   override lazy val validConstraints: ExpressionSet =
     getAllValidConstraints(projectList)
+
+  override def metadataOutput: Seq[Attribute] =
+    child.metadataOutput.filter(_.isHiddenCol) ++

Review comment:
       This was used in `natural-join.sql`:
   ```
   SELECT nt1.*, nt2.*, nt3.* FROM nt1 natural join nt2 natural join nt3;
   ```
   Which would otherwise fail to expand `nt2.*` to include the key column.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to