karenfeng commented on a change in pull request #31666:
URL: https://github.com/apache/spark/pull/31666#discussion_r608876724



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -77,6 +77,14 @@ case class Project(projectList: Seq[NamedExpression], child: 
LogicalPlan)
 
   override lazy val validConstraints: ExpressionSet =
     getAllValidConstraints(projectList)
+
+  override def metadataOutput: Seq[Attribute] =
+    child.metadataOutput.filter(_.isHiddenCol) ++

Review comment:
       To fix this, we could say that hidden columns are only propagated 
through `Project` with a `Star` in the `projectList`. Ideally, we'd only 
propagate the hidden columns that match the Star's qualifier, but I'm not sure 
if that's possible at that stage.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to