Yikun commented on a change in pull request #32118:
URL: https://github.com/apache/spark/pull/32118#discussion_r610988580
##########
File path: python/pyspark/sql/column.pyi
##########
@@ -116,3 +123,11 @@ class Column:
def __nonzero__(self) -> None: ...
def __bool__(self) -> None: ...
def contains(self, item: Any) -> Column: ...
+
+def _to_java_column(col: ColumnOrName) -> JavaObject: ...
Review comment:
Some note for reviewer: all missing type hints were [internal
use](https://pep8.org/#descriptive-naming-styles) methods as usual, but it
still be used by other modules:
https://github.com/apache/spark/blob/364d1eaf10f51c357f507325557fb076140ced2c/python/pyspark/pandas/spark/functions.py#L22
Looks like we should move these methods into pyspark.sql.utils or somewhere
in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
