Yikun edited a comment on pull request #32118: URL: https://github.com/apache/spark/pull/32118#issuecomment-817128098
> Could you explain what is the use case for adding these? The annotating missing warning was found when I cleaunup the mypy error of spark pandas, see more in [SPARK-34941](https://issues.apache.org/jira/browse/SPARK-34941). [python/pyspark/pandas/frame.py:6486](https://github.com/apache/spark/blob/214a46aa88cd682874584dc407ad130a30761884/python/pyspark/pandas/frame.py#L6486): error: Module 'pyspark.sql.types' has no attribute '_parse_datatype_string' [python/pyspark/pandas/spark/functions.py:22](https://github.com/apache/spark/blob/214a46aa88cd682874584dc407ad130a30761884/python/pyspark/pandas/spark/functions.py#L22): error: Module 'pyspark.sql.column' has no attribute '_to_java_column' [python/pyspark/pandas/spark/functions.py:22](https://github.com/apache/spark/blob/214a46aa88cd682874584dc407ad130a30761884/python/pyspark/pandas/spark/functions.py#L22): error: Module 'pyspark.sql.column' has no attribute '_to_seq' [python/pyspark/pandas/spark/functions.py:22](https://github.com/apache/spark/blob/214a46aa88cd682874584dc407ad130a30761884/python/pyspark/pandas/spark/functions.py#L22): error: Module 'pyspark.sql.column' has no attribute > In general we decided to avoid annotating private and internal code Yep, I also found this rule, so I mentioned in previous comment: https://github.com/apache/spark/pull/32118#discussion_r610988580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
