cloud-fan commented on a change in pull request #31920:
URL: https://github.com/apache/spark/pull/31920#discussion_r611445608
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
##########
@@ -51,7 +52,7 @@ object SQLExecution {
// started execution of a query didn't call withNewExecutionId. The
execution ID should be
// set by calling withNewExecutionId in the action that begins
execution, like
// Dataset.collect or DataFrameWriter.insertInto.
- throw new IllegalStateException("Execution ID should be set")
+ throw QueryExecutionErrors.executionIDNotSetError()
Review comment:
ditto
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala
##########
@@ -174,7 +175,7 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] with
Logging with Serializ
*/
final def execute(): RDD[InternalRow] = executeQuery {
if (isCanonicalizedPlan) {
- throw new IllegalStateException("A canonicalized plan is not supposed to
be executed.")
+ throw QueryExecutionErrors.executeCanonicalizedPlanError()
Review comment:
ditto
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala
##########
@@ -187,7 +188,7 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] with
Logging with Serializ
*/
final def executeBroadcast[T](): broadcast.Broadcast[T] = executeQuery {
if (isCanonicalizedPlan) {
- throw new IllegalStateException("A canonicalized plan is not supposed to
be executed.")
+ throw QueryExecutionErrors.executeCanonicalizedPlanError()
Review comment:
ditto
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala
##########
@@ -201,7 +202,7 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] with
Logging with Serializ
*/
final def executeColumnar(): RDD[ColumnarBatch] = executeQuery {
if (isCanonicalizedPlan) {
- throw new IllegalStateException("A canonicalized plan is not supposed to
be executed.")
+ throw QueryExecutionErrors.executeCanonicalizedPlanError()
Review comment:
ditto
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala
##########
@@ -294,7 +295,7 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] with
Logging with Serializ
* Overridden by concrete implementations of SparkPlan.
*/
protected[sql] def doExecuteBroadcast[T](): broadcast.Broadcast[T] = {
- throw new UnsupportedOperationException(s"$nodeName does not implement
doExecuteBroadcast")
+ throw QueryExecutionErrors.doExecuteBroadcastNotImplementedError(nodeName)
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
