cloud-fan commented on a change in pull request #31920:
URL: https://github.com/apache/spark/pull/31920#discussion_r611447834
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
##########
@@ -129,7 +130,7 @@ class RowBasedHashMapGenerator(
case t: DataType =>
if (!t.isInstanceOf[StringType] &&
!t.isInstanceOf[CalendarIntervalType] &&
!CodeGenerator.isPrimitiveType(t)) {
- throw new IllegalArgumentException(s"cannot generate code for
unsupported type: $t")
+ throw
QueryExecutionErrors.cannotGenerateCodeForUnsupportedTypeError(t)
Review comment:
ditto
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
##########
@@ -456,8 +457,7 @@ class TungstenAggregationIterator(
hashMap.free()
resultCopy
} else {
- throw new IllegalStateException(
- "This method should not be called when groupingExpressions is not
empty.")
+ throw QueryExecutionErrors.callMethodWithEmptyGroupingExpressionsError()
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
