Yikun commented on a change in pull request #32193:
URL: https://github.com/apache/spark/pull/32193#discussion_r614877626
##########
File path: .github/workflows/notify_test_workflow.yml
##########
@@ -13,28 +38,53 @@ jobs:
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
- const endpoint = "GET
/repos/:owner/:repo/actions/workflows/:id/runs?&branch=:branch"
+ const endpoint = 'GET
/repos/:owner/:repo/actions/workflows/:id/runs?&branch=:branch'
+
+ // TODO: Should use pull_request.user and
pull_request.user.repos_url?
+ // If a different person creates a commit to another forked repo,
+ // it wouldn't be able to detect.
const params = {
owner: context.payload.pull_request.head.repo.owner.login,
repo: context.payload.pull_request.head.repo.name,
- id: "build_and_test.yml",
+ id: 'build_and_test.yml',
branch: context.payload.pull_request.head.ref,
}
+ console.log('Ref: ' + context.payload.pull_request.head.ref)
+ console.log('SHA: ' + context.payload.pull_request.head.sha)
+
+ // Wait 3 seconds to make sure the fork repository triggered a
workflow.
+ await new Promise(r => setTimeout(r, 3000))
+
const runs = await github.request(endpoint, params)
- var runID = runs.data.workflow_runs[0].id
-
- var msg = "**[Test build #" + runID + "]"
- + "(https://github.com/"; +
context.payload.pull_request.head.repo.full_name
- + "/actions/runs/" + runID + ")** "
- + "for PR " + context.issue.number
- + " at commit [`" +
context.payload.pull_request.head.sha.substring(0, 7) + "`]"
- + "(https://github.com/"; +
context.payload.pull_request.head.repo.full_name
- + "/commit/" + context.payload.pull_request.head.sha + ")."
-
- github.issues.createComment({
- issue_number: context.issue.number,
- owner: context.payload.repository.owner.login,
- repo: context.payload.repository.name,
- body: msg
+ const runID = runs.data.workflow_runs[0].id
+ // TODO: If no workflows were found, it's likely GitHub Actions
was not enabled
+
+ if (runs.data.workflow_runs[0].head_sha !=
context.payload.pull_request.head.sha) {
+ throw new Error('There was a new unsynced commit pushed. Please
retrigger the workflow.');
+ }
Review comment:
Good update, this check resolve the problme of notify_test retrigger.
##########
File path: .github/workflows/update_build_status.yml
##########
@@ -0,0 +1,95 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Update build status workflow
+
+on:
+ schedule:
+ - cron: "*/15 * * * *"
+
+jobs:
+ update:
+ name: Update build status
+ runs-on: ubuntu-20.04
+ steps:
+ - name: "Update build status"
+ uses: actions/github-script@v3
+ with:
+ github-token: ${{ secrets.GITHUB_TOKEN }}
+ script: |
+ const endpoint = 'GET /repos/:owner/:repo/pulls?state=:state'
+ const params = {
+ owner: context.repo.owner,
+ repo: context.repo.repo,
+ state: 'open'
+ }
+
+ // See
https://docs.github.com/en/graphql/reference/enums#mergestatestatus
+ const maybeReady = ['behind', 'clean', 'draft', 'has_hooks',
'unknown', 'unstable'];
+
+ // Iterate open PRs
+ for await (const prs of github.paginate.iterator(endpoint,params))
{
+ // Each page
+ for await (const pr of prs.data) {
+ console.log('SHA: ' + pr.head.sha)
+ console.log(' Mergeable status: ' + pr.mergeable_state)
+ if (pr.mergeable_state == null ||
maybeReady.includes(pr.mergeable_state)) {
+ const checkRuns = await github.request('GET
/repos/{owner}/{repo}/commits/{ref}/check-runs', {
+ owner: context.repo.owner,
+ repo: context.repo.repo,
+ ref: pr.head.sha
Review comment:
If I understand correct, the latest patch still not cover the case
mentioned in
https://github.com/HyukjinKwon/spark/pull/42#issuecomment-821023453 .
We need do a double check using [Get Pull
Request](https://docs.github.com/en/rest/reference/pulls#get-a-pull-request),
and check `current_pr.head.sha` == `pr.head.sha`, if not equal we should use
`current_pr.head.sha` as the ref input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
