HyukjinKwon commented on a change in pull request #32193:
URL: https://github.com/apache/spark/pull/32193#discussion_r614908174
##########
File path: .github/workflows/notify_test_workflow.yml
##########
@@ -13,28 +38,53 @@ jobs:
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
- const endpoint = "GET
/repos/:owner/:repo/actions/workflows/:id/runs?&branch=:branch"
+ const endpoint = 'GET
/repos/:owner/:repo/actions/workflows/:id/runs?&branch=:branch'
+
+ // TODO: Should use pull_request.user and
pull_request.user.repos_url?
+ // If a different person creates a commit to another forked repo,
+ // it wouldn't be able to detect.
const params = {
owner: context.payload.pull_request.head.repo.owner.login,
repo: context.payload.pull_request.head.repo.name,
- id: "build_and_test.yml",
+ id: 'build_and_test.yml',
branch: context.payload.pull_request.head.ref,
}
+ console.log('Ref: ' + context.payload.pull_request.head.ref)
+ console.log('SHA: ' + context.payload.pull_request.head.sha)
+
+ // Wait 3 seconds to make sure the fork repository triggered a
workflow.
+ await new Promise(r => setTimeout(r, 3000))
+
const runs = await github.request(endpoint, params)
- var runID = runs.data.workflow_runs[0].id
-
- var msg = "**[Test build #" + runID + "]"
- + "(https://github.com/"; +
context.payload.pull_request.head.repo.full_name
- + "/actions/runs/" + runID + ")** "
- + "for PR " + context.issue.number
- + " at commit [`" +
context.payload.pull_request.head.sha.substring(0, 7) + "`]"
- + "(https://github.com/"; +
context.payload.pull_request.head.repo.full_name
- + "/commit/" + context.payload.pull_request.head.sha + ")."
-
- github.issues.createComment({
- issue_number: context.issue.number,
- owner: context.payload.repository.owner.login,
- repo: context.payload.repository.name,
- body: msg
+ const runID = runs.data.workflow_runs[0].id
+ // TODO: If no workflows were found, it's likely GitHub Actions
was not enabled
+
+ if (runs.data.workflow_runs[0].head_sha !=
context.payload.pull_request.head.sha) {
+ throw new Error('There was a new unsynced commit pushed. Please
retrigger the workflow.');
+ }
Review comment:
So I think the cause of the issue you faced is here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
