Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/5589#discussion_r29378782
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -518,6 +518,9 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
_taskScheduler.postStartHook()
_env.metricsSystem.registerSource(new DAGSchedulerSource(dagScheduler))
_env.metricsSystem.registerSource(new
BlockManagerSource(_env.blockManager))
+ _executorAllocationManager.foreach { e =>
--- End diff --
The model for the other metric sources seems to be that the source wraps
the object. What's the reason for having the source inside of the
ExecutorAllocationManager in this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
