sunchao commented on a change in pull request #32082:
URL: https://github.com/apache/spark/pull/32082#discussion_r618105900
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala
##########
@@ -154,6 +154,26 @@ private[sql] trait LookupCatalog extends Logging {
}
}
+ object AsFunctionIdentifier {
+ def unapply(parts: Seq[String]): Option[FunctionIdentifier] = {
+ def namesToFunctionIdentifier(names: Seq[String]):
Option[FunctionIdentifier] = names match {
+ case Seq(name) => Some(FunctionIdentifier(name))
+ case Seq(database, name) => Some(FunctionIdentifier(name,
Some(database)))
+ case _ => None
+ }
+ parts match {
+ case CatalogAndMultipartIdentifier(None, names)
+ if CatalogV2Util.isSessionCatalog(currentCatalog) =>
+ namesToFunctionIdentifier(names)
+ case CatalogAndMultipartIdentifier(Some(catalog), names)
+ if CatalogV2Util.isSessionCatalog(catalog) &&
+ CatalogV2Util.isSessionCatalog(currentCatalog) =>
Review comment:
I followed `AsTableIdentifier` for this check and see related comments
[here](https://github.com/apache/spark/pull/30919#discussion_r549610277). But
looking at it now, I think it should be OK to remove this check for both
function and table identifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
