sunchao commented on a change in pull request #32082:
URL: https://github.com/apache/spark/pull/32082#discussion_r618192035
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -269,23 +269,24 @@ case class UnresolvedGenerator(name: FunctionIdentifier,
children: Seq[Expressio
}
case class UnresolvedFunction(
- name: FunctionIdentifier,
+ multipartIdentifier: Seq[String],
arguments: Seq[Expression],
isDistinct: Boolean,
filter: Option[Expression] = None,
ignoreNulls: Boolean = false)
extends Expression with Unevaluable {
+ import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
override def children: Seq[Expression] = arguments ++ filter.toSeq
override def dataType: DataType = throw new UnresolvedException("dataType")
override def nullable: Boolean = throw new UnresolvedException("nullable")
override lazy val resolved = false
- override def prettyName: String = name.unquotedString
+ override def prettyName: String = multipartIdentifier.quoted
override def toString: String = {
val distinct = if (isDistinct) "distinct " else ""
- s"'$name($distinct${children.mkString(", ")})"
+ s"'${multipartIdentifier.quoted}($distinct${children.mkString(", ")})"
Review comment:
Thanks @cloud-fan ! in that case I think it is still valid here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
