sarutak commented on a change in pull request #32190:
URL: https://github.com/apache/spark/pull/32190#discussion_r618170592
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -562,10 +577,16 @@ $(document).ready(function () {
}
],
"columnDefs": [
- { "visible": false, "targets": 15 },
- { "visible": false, "targets": 16 },
- { "visible": false, "targets": 17 },
- { "visible": false, "targets": 18 }
+ // String with structures like : 'bytes / bytes',
'bytes / bytes'
+ // they should be sorted as numerical-order instead of
lexicographical-order.
+ { "type": "size", "targets": 9 },
+ { "type": "size", "targets": 10 },
+ { "type": "size", "targets": 11 },
+ { "type": "size", "targets": 12 },
+ { "type": "size", "visible": false, "targets": 15 },
Review comment:
The type of col 15 - 18 seems to be number but how about col 13 and
col14? They seems to be text.
https://github.com/apache/spark/blob/b17a0e6931cac98cc839c047b1b5d4ea6d052009/core/src/main/resources/org/apache/spark/ui/static/stagepage.js#L482
BTW, please don't resolve conversations. It's difficult to confirm what we
pointed out is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
