sarutak commented on a change in pull request #32190:
URL: https://github.com/apache/spark/pull/32190#discussion_r618171154
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -562,10 +579,23 @@ $(document).ready(function () {
}
],
"columnDefs": [
- { "visible": false, "targets": 15 },
- { "visible": false, "targets": 16 },
- { "visible": false, "targets": 17 },
- { "visible": false, "targets": 18 }
+ // SPARK-35087 [type:size] means String with
structures like : 'size / records',
+ // they should be sorted as numerical-order instead of
lexicographical-order by default.
+ // The targets: $id represents column id which comes
from stagespage-template.html
+ // #summary-executor-table.If the relative position of
the columns in the table
+ // #summary-executor-table has changed,please be
careful to adjust the column index here
+ // Input Size / Records
+ {"type": "size", "targets": 9},
+ // Output Size / Records
+ {"type": "size", "targets": 10},
+ // Shuffle Read Size / Records
+ {"type": "size", "targets": 11},
+ // Shuffle Write Size / Records
+ {"type": "size", "targets": 12},
+ {"visible": false, "targets": 15},
+ {"visible": false, "targets": 16},
+ {"visible": false, "targets": 17},
+ {"visible": false, "targets": 18}
Review comment:
Now that we touch here, how about add comments for col 15 - 18?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
