luhenry commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r619494235
##########
File path: mllib-local/pom.xml
##########
@@ -75,6 +75,11 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
+ </dependency>
Review comment:
As updated in the description, the order in which each implementations
are used is the following:
```
| | BLAS.nativeBLAS
| BLAS.javaBLAS |
| --------------------- | --------------------------------------------------
| -------------------------------------------------- |
| with -Pnetlib-lgpl | 1. dev.ludovic.netlib.blas.ForeignBLAS (JDK16+,
| 1. dev.ludovic.netlib.blas.VectorizedBLAS |
| | relies on the Foreign Memory API, requires
| (JDK16+, relies on the Vector API, requires |
| | --add-modules=jdk.incubator.foreign
| --add-modules=jdk.incubator.vector on JDK16) |
| | -Dforeign.restricted=warn)
| 2. dev.ludovic.netlib.blas.Java11BLAS (JDK11+) |
| | 2. dev.ludovic.netlib.blas.NetlibNativeBLAS, a
| 3. dev.ludovic.netlib.blas.JavaBLAS |
| | wrapper for com.github.fommil:all
| 4. dev.ludovic.netlib.blas.NetlibF2jBLAS, a |
| | 3. fails to load, falls back to BLAS.javaBLAS in
| wrapper for com.github.fommil:core |
| | org.apache.spark.ml.linalg.BLAS
| |
| --------------------- | --------------------------------------------------
| -------------------------------------------------- |
| without -Pnetlib-lgpl | 1. dev.ludovic.netlib.blas.ForeignBLAS (JDK16+,
| 1. dev.ludovic.netlib.blas.VectorizedBLAS |
| | relies on the Foreign Memory API, requires
| (JDK16+, relies on the Vector API, requires |
| | --add-modules=jdk.incubator.foreign
| --add-modules=jdk.incubator.vector on JDK16) |
| | -Dforeign.restricted=warn)
| 2. dev.ludovic.netlib.blas.Java11BLAS (JDK11+) |
| | 2. fails to load, falls back to BLAS.javaBLAS in
| 3. dev.ludovic.netlib.blas.JavaBLAS |
| | org.apache.spark.ml.linalg.BLAS
| 4. dev.ludovic.netlib.blas.NetlibF2jBLAS, a |
| |
| wrapper for com.github.fommil:core |
| --------------------- | --------------------------------------------------
| -------------------------------------------------- |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
