luhenry commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r619327385
##########
File path: mllib-local/pom.xml
##########
@@ -75,6 +75,11 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
+ </dependency>
Review comment:
Today, `dev.ludovic.netlib` does call
`com.github.fommil.netlib.BLAS.getInstance()` to probe whether the native
libraries are installed. (This call is in `com.github.fommil:core` and is thus
all good regarding licensing.) If we remove the content of the `netlib-lgpl`
profile and the dependency on `com.github.fommil:all` then we will break the
current behavior of probing for native BLAS implementation through
`com.github.fommil:native_ref` and `com.github.fommil:native_system`.
In the future, I do want to add JNI-based prober/wrapper for BLAS, LAPACK,
and ARPACK (and which are compliment with licensing as discussed above), but
that is not done yet. Then, we will be able to remove the reference to
`com.github.fommil:all`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
