xkrogen commented on a change in pull request #32388:
URL: https://github.com/apache/spark/pull/32388#discussion_r623210177
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
##########
@@ -291,9 +294,18 @@ public ShuffleMetrics() {
allMetrics.put("openBlockRequestLatencyMillis",
openBlockRequestLatencyMillis);
allMetrics.put("registerExecutorRequestLatencyMillis",
registerExecutorRequestLatencyMillis);
allMetrics.put("finalizeShuffleMergeLatencyMillis",
finalizeShuffleMergeLatencyMillis);
+ allMetrics.put("blockTransferRate", blockTransferRate);
allMetrics.put("blockTransferRateBytes", blockTransferRateBytes);
+ allMetrics.put("blockTransferAvgSize_1min", new RatioGauge() {
+ @Override
+ protected Ratio getRatio() {
+ return Ratio.of(
+ blockTransferRateBytes.getOneMinuteRate(),
+ blockTransferRate.getOneMinuteRate());
+ }
+ });
allMetrics.put("registeredExecutorsSize",
- (Gauge<Integer>) () ->
blockManager.getRegisteredExecutorsSize());
+ (Gauge<Integer>) blockManager::getRegisteredExecutorsSize);
Review comment:
Yes, this is a Java 8 "method reference". Read more about them
[here](https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html)
(note that at the top of the page it says it is written against JDK 8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
