xkrogen commented on a change in pull request #32388:
URL: https://github.com/apache/spark/pull/32388#discussion_r623211422
##########
File path:
resource-managers/yarn/src/test/scala/org/apache/spark/network/yarn/YarnShuffleServiceMetricsSuite.scala
##########
@@ -37,28 +38,57 @@ class YarnShuffleServiceMetricsSuite extends SparkFunSuite
with Matchers {
val metrics = new ExternalBlockHandler(streamManager,
blockResolver).getAllMetrics
test("metrics named as expected") {
- val allMetrics = Set(
+ val allMetrics = Seq(
Review comment:
I think the comment below explains. You can't sort a `Set` so if we use
`Set` here we have to call `toSeq.sorted` -- we might as well just use `Seq` to
begin with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
